fix(UBNetworkAccessManager): Use atomic_int instead of volatile #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volatile is intended for hardware interaction, where changes might not be obvious from the given code, disabling certain compiler features. The intended use is atomic operations, so use that instead.
Vekhir
force-pushed
the
atomic-for-thread-safety
branch
from
42b1e55 to
ab17733
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volatileis intended for hardware interaction, where changes might not be obvious from the given code, disabling certain compiler features.The intended use is atomic operations, so use that instead.
There are other uses of
volatilewhich probably mean to be atomic, but they are mostly in the recording section which I can't really test, don't want to test, and since they don't create warnings should probably be left alone.Resolves warning 5 of #1046